Add Google Tag Manager (GTM) Integration

Description

Add the newer Google Tag Manager integration to the Core.

This should be used in line with Standard analytics so if an application is using GTM - the standard Analytics should be disabled to avoid double hit counts.

Details can be found here:
https://tagmanager.google.com

https://www.google.com/analytics/tag-manager/

Activity

Show:
Mitrah Soft
June 1, 2018, 12:34 PM

hi @domwatson ,

  • I've completed this ticket and committed in feature_PRESIDECMS-827 Branch.

This ticket needs to work in both Preside-CMS and Preside-CMS-Skeleton Repo's .

Here are the PR details :

Preside-CMS - https://github.com/pixl8/Preside-CMS/pull/516
Preside-CMS-Skeleton - https://github.com/pixl8/Preside-CMS-Skeleton/pull/4

Please check that and Let me know if any update needed .

Dominic Watson
June 7, 2018, 1:02 PM

Hey guys, thanks for this. I have a strong feeling that this should be an extension that follows the same pattern as: https://github.com/pixl8/preside-ext-google-analytics.

Apologies for not triaging the ticket sooner and making that clear. However, general rules:

  • If a JIRA ticket hasn't been marked as "Accepted", then its worth asking about it before going ahead

  • If the feature is about integrating with a proprietary third party (i.e. Google), then it should probably not belong in core

Going to close this ticket for now.

Assignee

Unassigned

Reporter

Niall O'Doherty

Labels

None

Accepted

None

Priority

Medium
Configure