Identified potential race conditions missing var

Description

/preside/system/services/i18n/i18n.cfc line 87,88,167,168 unvarred

/preside/system/handlers/formbuilder/item-types/matrix.cfc line 55 qa unvarred

/preside/system/services/email/EmailService.cfc line 155,157 missing var

/system/services/siteTree/SiteTemplatesService.cfc missing var line 37

/preside/system/services/presideObjects/VersioningService.cfc missing var line 603

/preside/system/handlers/admin/devtools/terminalCommands/New.cfc missing var for filesCreated on lines 286,336,370,411,460,503

 

/website/preside/system/coldboxModifications/services/RoutingService.cfc line 129 interceptdata is unvarred but is it that it is meant to be an argument which instead is interceptor when all others are interceptdata ??

 

/preside/system/services/notifications/NotificationService.cfc line 151 and 606 unvarred

/preside/system/services/updateManager/UpdateManagerService.cfc line 355 unvarred

/preside/system/handlers/rules/expressions/UserHasBenefits.cfc line hasBenefits is not varred 37 and 39

/preside/system/services/authentication/GoogleAuthenticator.cfc byte and byte2 unvarred in Base32Encode() function

 

/preside/system/externals/cfconcurrent/ExecutorCompletionService.cfc completionQueueProcessFuture is not varred but should it be variables. explict ??

 

Should /preside/system/handlers/admin/DataManager.cfc line 1905 be varred ??

 

/preside/system/coldboxModifications/RequestContextDecorator.cfc should line 771 and 844 be varred ?:

/system/services/assetManager/ImageManipulationService.cfc fitRatio line 136 should be varred

Environment

None

Status

Assignee

Unassigned

Reporter

Alex Skinner

Labels

None

Accepted

None

Priority

Medium
Configure